Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verifiers #17

Merged
merged 5 commits into from
Sep 12, 2023
Merged

Verifiers #17

merged 5 commits into from
Sep 12, 2023

Conversation

j2kun
Copy link
Owner

@j2kun j2kun commented Sep 8, 2023

No description provided.

This is because I noticed the assembly format was printing <10> for
polynomials instead of the fully qualified type name. After this commit
it will print the whole type

See https://mlir.llvm.org/docs/DefiningDialects/Operations/#declarative-assembly-format
for more details.
This removes the flexibility of having mixed poly + tensor ops for the
binary operations, but demonstrates how the type inference engine
enables a more succinct textual IR.

If you were to simplify the assembly format without doing this, you'd
get a compile-time error complaining that it can't infer the type of the
operands or argument.
@j2kun j2kun merged commit 031e5fe into main Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant